Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-renderer): base tag should be before any link or script tag #7376

Merged
merged 1 commit into from
May 16, 2020

Conversation

pimlie
Copy link

@pimlie pimlie commented May 16, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Resolves: #7250

Description

See: #7250 (comment)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

Codecov Report

Merging #7376 into dev will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7376      +/-   ##
==========================================
- Coverage   70.63%   70.58%   -0.06%     
==========================================
  Files          88       88              
  Lines        3600     3604       +4     
  Branches      976      977       +1     
==========================================
+ Hits         2543     2544       +1     
- Misses        857      859       +2     
- Partials      200      201       +1     
Flag Coverage Δ
#unittests 70.58% <0.00%> (-0.06%) ⬇️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/ssr.js 0.00% <0.00%> (ø)
packages/cli/src/commands/serve.js 72.41% <0.00%> (-2.59%) ⬇️
packages/cli/src/imports.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b29124...9d93648. Read the comment docs.

@pi0 pi0 merged commit 224c379 into dev May 16, 2020
@pi0 pi0 deleted the fix-meta-base-before-link-script branch May 16, 2020 16:03
@pi0 pi0 mentioned this pull request Jun 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuxt.config.js 里設置router.base后,對static下的文件引用出錯
4 participants