Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set build indicator icon height for ie11 #7378

Merged
merged 1 commit into from
May 17, 2020
Merged

fix: set build indicator icon height for ie11 #7378

merged 1 commit into from
May 17, 2020

Conversation

sibbng
Copy link

@sibbng sibbng commented May 17, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Related #7377

Before
image

After
image

/cc @pi0

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

Codecov Report

Merging #7378 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7378   +/-   ##
=======================================
  Coverage   70.58%   70.58%           
=======================================
  Files          88       88           
  Lines        3604     3604           
  Branches      977      977           
=======================================
  Hits         2544     2544           
  Misses        859      859           
  Partials      201      201           
Flag Coverage Δ
#unittests 70.58% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f6b19...dc71b13. Read the comment docs.

@pi0 pi0 changed the title fix: adjust build indicator nuxt icon height fix: set build indicator icon height for ie11 May 17, 2020
@pi0 pi0 merged commit 0c81c52 into nuxt:dev May 17, 2020
@pi0 pi0 mentioned this pull request Jun 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants