Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modern): wrong assets mapping in ssr client modern mode #7382

Merged
merged 1 commit into from
May 17, 2020

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented May 17, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix #7311

When there're multiple async chunks in a component, the client modern mode is wrongly mapping, this pr is fixing this issue by using array to map between legacy and modern files.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from a team May 17, 2020 13:33
@clarkdo clarkdo self-assigned this May 17, 2020
@pi0 pi0 merged commit b1b1403 into dev May 17, 2020
@pi0 pi0 deleted the fix/ssr-modern-client branch May 17, 2020 19:41
@pi0 pi0 mentioned this pull request Jun 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modern client mode behaves differently for including async chunks on initial page load
3 participants