-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue-renderer): fix meta injection when ssr renderer generates a spa page #7439
Conversation
…rate non-ssr page (ie on redirects)
Codecov Report
@@ Coverage Diff @@
## dev #7439 +/- ##
==========================================
- Coverage 70.20% 70.16% -0.04%
==========================================
Files 88 88
Lines 3715 3717 +2
Branches 1008 1008
==========================================
Hits 2608 2608
- Misses 899 901 +2
Partials 208 208
Continue to review full report at Codecov.
|
feat: show linebreak between tags during development for easier meta debugging
@pi0 It seems that the tests are logging the following message, is that a known issue? Ie its not just just for me locally but also in the 2.13 draft pr
|
This PR also adds the change that during development all generated tags by vue-meta will be appended by a line break. |
Types of changes
Resolves: nuxt/vue-meta#567
Description
On nuxt generate in universal mode normally all pages are
serverRendered: true
, but redirects will be generated as a spa. This PR makes sure that vue-meta is aware of that as well and doesnt add its own ssr attributes.Checklist: