Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-renderer): fix meta injection when ssr renderer generates a spa page #7439

Merged
merged 6 commits into from
Jun 10, 2020

Conversation

pimlie
Copy link

@pimlie pimlie commented May 30, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Resolves: nuxt/vue-meta#567

Description

On nuxt generate in universal mode normally all pages are serverRendered: true, but redirects will be generated as a spa. This PR makes sure that vue-meta is aware of that as well and doesnt add its own ssr attributes.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2020

Codecov Report

Merging #7439 into dev will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7439      +/-   ##
==========================================
- Coverage   70.20%   70.16%   -0.04%     
==========================================
  Files          88       88              
  Lines        3715     3717       +2     
  Branches     1008     1008              
==========================================
  Hits         2608     2608              
- Misses        899      901       +2     
  Partials      208      208              
Flag Coverage Δ
#unittests 70.16% <0.00%> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/ssr.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c48a834...ec605f6. Read the comment docs.

@pimlie pimlie self-assigned this Jun 10, 2020
@pimlie
Copy link
Author

pimlie commented Jun 10, 2020

@pi0 It seems that the tests are logging the following message, is that a known issue? Ie its not just just for me locally but also in the 2.13 draft pr

ReferenceError: You are trying to `import` a file after the Jest environment has been torn down.

@pimlie
Copy link
Author

pimlie commented Jun 10, 2020

This PR also adds the change that during development all generated tags by vue-meta will be appended by a line break.

@pi0 pi0 merged commit df7e1ad into dev Jun 10, 2020
@pimlie pimlie deleted the fix-vue-meta-ssr-renderer branch June 10, 2020 15:28
@pi0 pi0 mentioned this pull request Jun 12, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title not updated on page redirect from SSR
4 participants