chore: fix minor issues in build scripts #7458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #7458 +/- ##
=======================================
Coverage 70.32% 70.32%
=======================================
Files 88 88
Lines 3704 3704
Branches 1010 1010
=======================================
Hits 2605 2605
Misses 892 892
Partials 207 207
Continue to review full report at Codecov.
|
danielroe
commented
Jun 3, 2020
Comment on lines
-242
to
-246
| // Encountered an unrecoverable error | ||
| case 'FATAL': | ||
| this.formatError(event.error) | ||
| return this.logger.fatal(event.error) | ||
|
|
There was a problem hiding this comment.
There is no longer a FATAL event.
danielroe
commented
Jun 3, 2020
| @@ -27,7 +29,7 @@ async function main () { | |||
| // Step 1: Apply suffixes | |||
| for (const pkg of workspacePackages) { | |||
| if (pkg.options.suffix && pkg.options.suffix.length) { | |||
| await pkg.suffixAndVersion() | |||
| pkg.suffixAndVersion() | |||
There was a problem hiding this comment.
This is not an async method.
danielroe
commented
Jun 3, 2020
| exec (command, args, silent = false) { | ||
| const r = spawn.sync(command, args.split(' '), { cwd: this.options.rootDir }, { env: process.env }) | ||
| const r = spawn.sync(command, args.split(' '), { cwd: this.options.rootDir, env: process.env }) |
There was a problem hiding this comment.
cross-spawn doesn't take a third parameter
|
Thanks @danielroe for improvements But i think having tsdocs for internal build scripts is unnecessary complexity until we migrate repo to typescript for nuxt3 |
danielroe
changed the title
manniL
approved these changes
Jun 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This fixes a couple of minor issues (see GitHub comments).
Checklist: