Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): enhance generate no-build description (#6031) #7460

Merged
merged 1 commit into from
Jun 4, 2020
Merged

chore(cli): enhance generate no-build description (#6031) #7460

merged 1 commit into from
Jun 4, 2020

Conversation

dtmzr
Copy link

@dtmzr dtmzr commented Jun 3, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

In #6031 enhancing the description for generate --build was requested, I hope rephrasing and adding some information helps.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

Codecov Report

Merging #7460 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7460   +/-   ##
=======================================
  Coverage   70.32%   70.32%           
=======================================
  Files          88       88           
  Lines        3704     3704           
  Branches     1010     1010           
=======================================
  Hits         2605     2605           
  Misses        892      892           
  Partials      207      207           
Flag Coverage Δ
#unittests 70.32% <ø> (ø)
Impacted Files Coverage Δ
packages/cli/src/commands/generate.js 93.75% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be726e4...324ca0d. Read the comment docs.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! BTW new nuxt export command is progressive (in way of build once) by default

@pi0 pi0 merged commit b45f284 into nuxt:dev Jun 4, 2020
@pi0 pi0 mentioned this pull request Jun 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants