Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): not strip trailing slash for redirect external domain #7533

Merged
merged 5 commits into from
Jun 18, 2020

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jun 16, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Add test for #7475

When redirect to external domain, not strip trailing slash.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from pi0 June 16, 2020 20:33
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #7533 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7533   +/-   ##
=======================================
  Coverage   70.21%   70.21%           
=======================================
  Files          88       88           
  Lines        3740     3740           
  Branches     1017     1017           
=======================================
  Hits         2626     2626           
  Misses        905      905           
  Partials      209      209           
Flag Coverage Δ
#unittests 70.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cfaf0a...c8cfcd8. Read the comment docs.

@clarkdo clarkdo added the WIP label Jun 16, 2020
@clarkdo clarkdo removed the WIP label Jun 17, 2020
@pi0 pi0 merged commit 7f1429e into dev Jun 18, 2020
@pi0 pi0 deleted the fix/redirect-external branch June 18, 2020 15:32
@pi0 pi0 mentioned this pull request Jun 18, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants