Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix module and typescript compatibility and add missing crawler definition #7590

Merged
merged 5 commits into from
Jun 23, 2020

Conversation

kevinmarrec
Copy link
Contributor

@kevinmarrec kevinmarrec commented Jun 23, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Configuration needs to be an interface to be extended by modules types and be compatible with old/current modules.
  • NuxtOptions should now be extended by new modules instead of Configuration
    • It is extending Configuration to support modules still using it
    • NuxtConfig is the right import to do over Configuration in configuration files, and it inherits Configuration through NuxtOptions.
  • Add missing crawler config (fixes Missed crawler field definition in NuxtOptionsGenerate #7585)
  • Do not use export * as of issues with typescript < 3.9

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@kevinmarrec kevinmarrec requested a review from pi0 June 23, 2020 09:56
@kevinmarrec
Copy link
Contributor Author

kevinmarrec commented Jun 23, 2020

@pi0 I'm unsure, the issue is that :

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2020

Codecov Report

Merging #7590 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7590   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files          88       88           
  Lines        3747     3747           
  Branches     1020     1020           
=======================================
  Hits         2633     2633           
  Misses        905      905           
  Partials      209      209           
Flag Coverage Δ
#unittests 70.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c8b9b...d892045. Read the comment docs.

@pi0
Copy link
Member

pi0 commented Jun 23, 2020

It's also not deprecated cause modules extend it

Indeed. For me deprecated means something was possible, it is currently still possible but is not encouraged and will not be possible in future versions :D

@pi0 pi0 changed the title fix(types): fix Configuration interface types: fix Configuration interface Jun 23, 2020
@pi0 pi0 changed the title types: fix Configuration interface types: fix 2.13 types Jun 23, 2020
@pi0 pi0 changed the title types: fix 2.13 types types: fix module and typescript compatibility and add missing crawler definition Jun 23, 2020
@pi0 pi0 merged commit c004070 into dev Jun 23, 2020
@pi0 pi0 deleted the fix-types branch June 23, 2020 15:44
@pi0 pi0 mentioned this pull request Jun 23, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missed crawler field definition in NuxtOptionsGenerate
4 participants