Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): don't use absolute path of .cache/nuxt as transpilation pattern #7775

Merged
merged 4 commits into from
Jul 27, 2020

Conversation

danielroe
Copy link
Member

closes #7774

If static.cacheDir isn't set, this won't add the fully resolved cache directory but instead just .cache/nuxt as a transpilation pattern.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #7774

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

…attern

closes `nuxt-edge` doesn't respect targets in generation nuxt#7774
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2020

Codecov Report

Merging #7775 into dev will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7775      +/-   ##
==========================================
- Coverage   68.85%   68.83%   -0.02%     
==========================================
  Files          90       90              
  Lines        3824     3825       +1     
  Branches     1034     1035       +1     
==========================================
  Hits         2633     2633              
  Misses        968      968              
- Partials      223      224       +1     
Flag Coverage Δ
#unittests 68.83% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cli/src/utils/generate.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c6923...899951f. Read the comment docs.

@danielroe danielroe marked this pull request as ready for review July 26, 2020 11:50
pi0
pi0 previously approved these changes Jul 26, 2020
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If absolute path is problematic, shall we ensure it is always relative pattern or remove static.cacheDir support at all or add a warning for full path?

@danielroe
Copy link
Member Author

If absolute path is problematic, shall we ensure it is always relative pattern or remove static.cacheDir support at all or add a warning for full path?

@pi0 I don't think a relative path will work either (e.g. with a leading ./) because it's being tested against the file pattern. I think let's remove support for adding transpile for custom staticPath, and leave it (with warning) for the person who uses the custom path.

One approach: 4a3ba0d

@pi0 pi0 merged commit 5f7d675 into nuxt:dev Jul 27, 2020
@danielroe danielroe deleted the 7774-fix-cache-transpile branch July 27, 2020 09:31
@pi0 pi0 mentioned this pull request Jul 27, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuxt-edge doesn't respect targets in generation
3 participants