Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): empty $fetch function for SSR with static target #8053

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

Kolobok12309
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Add empty function $fetch to server fetch mixin
Now while ssr $fetch is undefined, and vue can throw errors on it

Resolves: #8043

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

Codecov Report

Merging #8053 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8053   +/-   ##
=======================================
  Coverage   68.98%   68.98%           
=======================================
  Files          91       91           
  Lines        3847     3847           
  Branches     1047     1047           
=======================================
  Hits         2654     2654           
  Misses        969      969           
  Partials      224      224           
Flag Coverage Δ
#unittests 68.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8b3a9...b9185ee. Read the comment docs.

@pi0 pi0 changed the title fix(vue-app): empty function $fetch to ssr fix(vue-app): empty $fetch function for SSR Sep 10, 2020
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 45b7838 into nuxt:dev Sep 10, 2020
@pi0 pi0 changed the title fix(vue-app): empty $fetch function for SSR fix(vue-app): empty $fetch function for SSR with static target Sep 10, 2020
@pi0 pi0 mentioned this pull request Sep 21, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property or method "$fetch" is not defined on the instance but referenced during render.
4 participants