Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add type for serverMiddleware object format #8182

Merged
merged 1 commit into from Oct 10, 2020

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Oct 10, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This adds the necessary type for the new feature added in #6414

Resolves: #8168

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

Codecov Report

Merging #8182 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8182   +/-   ##
=======================================
  Coverage   68.92%   68.92%           
=======================================
  Files          91       91           
  Lines        3855     3855           
  Branches     1049     1049           
=======================================
  Hits         2657     2657           
  Misses        973      973           
  Partials      225      225           
Flag Coverage Δ
#unittests 68.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c9dc3...3710fe5. Read the comment docs.

@danielroe danielroe marked this pull request as ready for review October 10, 2020 11:20
@pi0 pi0 merged commit a748cf0 into nuxt:dev Oct 10, 2020
@pi0 pi0 mentioned this pull request Oct 13, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[types] serverMiddleware object format not supported
3 participants