Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): nested route missing trailingSlash #8237

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

cain
Copy link

@cain cain commented Oct 21, 2020

Fixes issue #8165

I need some help finding the root of this issue. This fix just fixes the route path when generating the route, but would be good to find out where the child route is being created and adding the trailing slash there.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@cain cain force-pushed the bugfix-nested-trailing-slash branch from 793827b to 7785879 Compare October 21, 2020 23:35
@cain cain force-pushed the bugfix-nested-trailing-slash branch from 7785879 to 4677603 Compare October 21, 2020 23:37
@mornir
Copy link

mornir commented Oct 28, 2020

Hi @manniL if I'm not mistaken, you have a good knowledge about this topic (trailing slash in Nuxt). When you have the time, could you help us with this PR? 🙇‍♂️

To summarize: using nuxt-child with the trailingSlash option results in 404 in route generation. More info and reproduction in the issue #8165.

(If my memory serves me right, this issue was not present before Nuxt 2.14).

@cain
Copy link
Author

cain commented Oct 28, 2020

@mornir thanks for helping! :)

@clarkdo clarkdo requested review from manniL, a team and pi0 and removed request for a team October 29, 2020 20:54
@pi0 pi0 merged commit b80056c into nuxt:dev Nov 25, 2020
@pi0
Copy link
Member

pi0 commented Nov 25, 2020

Thanks for PR <3 You may use nuxt-edge in few minutes with patch applied.

@pi0 pi0 mentioned this pull request Nov 30, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants