Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): use nuxt globalName correctly in nuxt-link and fetch mixin #8289

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

danielroe
Copy link
Member

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

History: this.$nuxt accidentally crept in in the static target PR (#6159). This caused an error which was solved by testing for this.$nuxt rather than using globalName (#7766) as is done elsewhere in the component (see #4743)

This PR reverts to using globalName.

Resolves #8118

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #8289 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8289   +/-   ##
=======================================
  Coverage   68.70%   68.70%           
=======================================
  Files          91       91           
  Lines        3863     3863           
  Branches     1051     1051           
=======================================
  Hits         2654     2654           
  Misses        982      982           
  Partials      227      227           
Flag Coverage Δ
unittests 68.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baf94d3...0004d4e. Read the comment docs.

@danielroe danielroe marked this pull request as ready for review November 3, 2020 12:40
@danielroe
Copy link
Member Author

e2e tests should pass when #8282 is merged

@clarkdo clarkdo merged commit 442b6c0 into nuxt:dev Nov 4, 2020
@kswedberg
Copy link

thank you!

@danielroe danielroe deleted the 8118-custom-global-name-in-nuxt-link branch November 4, 2020 17:09
@pi0 pi0 mentioned this pull request Nov 6, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference in nuxt-link.client.js to this.$nuxt causes error when custom globalName is set
4 participants