Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add missing isFetching and nbFetching to NuxtApp interface #8349

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

mathieutu
Copy link

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Everything is in the title!

Thanks.

@codecov-io
Copy link

Codecov Report

Merging #8349 (ac64b7c) into dev (57aa7cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8349   +/-   ##
=======================================
  Coverage   68.55%   68.55%           
=======================================
  Files          91       91           
  Lines        3876     3876           
  Branches     1056     1056           
=======================================
  Hits         2657     2657           
  Misses        991      991           
  Partials      228      228           
Flag Coverage Δ
unittests 68.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57aa7cc...ac64b7c. Read the comment docs.

@mathieutu mathieutu changed the title [Types] Add missing nbFetching on NuxtApp Type [Types] Add missing isFetching and nbFetching on NuxtApp Type Nov 15, 2020
@pi0 pi0 changed the title [Types] Add missing isFetching and nbFetching on NuxtApp Type fix(types): add missing isFetching and nbFetching to NuxtApp interface Nov 16, 2020
@pi0 pi0 merged commit f36a6a0 into nuxt:dev Nov 16, 2020
@pi0
Copy link
Member

pi0 commented Nov 16, 2020

Thanks!

@pi0 pi0 mentioned this pull request Nov 30, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants