Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-preset-app): avoid rely on preset-env utils #8883

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

JLHwung
Copy link

@JLHwung JLHwung commented Feb 23, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Refactored to avoid depending on @babel/preset-env internals.

Closes #8881

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@JLHwung JLHwung marked this pull request as ready for review February 23, 2021 01:45
@lewebsimple
Copy link
Contributor

Looks good !

@pi0 pi0 changed the title fix: avoid rely on preset-env internals fix(babel-preset-app): avoid rely on preset-env utils Feb 23, 2021
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 4e3613f into nuxt:dev Feb 23, 2021
@pi0
Copy link
Member

pi0 commented Feb 23, 2021

After updating to babel to 7.13 (upstream regression) nuxt is broken (ci log)

.nuxt/client.js: Internal error in the corejs2 provider: unknown polyfill "es6.array.slice".

Trying to investigate...

Copy link
Member

danielroe commented Feb 23, 2021

I think this polyfill resolution worked for core-js@3 but not 2.

@pi0 pi0 mentioned this pull request Feb 23, 2021
7 tasks
@JLHwung JLHwung deleted the avoid-preset-env-internals branch February 24, 2021 16:14
This was referenced Mar 12, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants