Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack): use backported version of watchpack2 and latest chokidar #8890

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 23, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Current version of nuxt uses webpack@4 that depends on watchpack@1

warning nuxt > @nuxt/webpack > webpack > watchpack > watchpack-chokidar2 > chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.

This PR replaces watcher to use watchpack@4 (backported from webpack@5) to use latest version of chokidar

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested review from clarkdo and a team February 23, 2021 11:01
@pi0 pi0 changed the title feat(webpack): use watchpack2 feat(webpack): use backported version of watchpack2 [backport] Feb 23, 2021
@pi0 pi0 changed the title feat(webpack): use backported version of watchpack2 [backport] feat(webpack): use backported version of watchpack2 and latest chokidar Feb 23, 2021
@pi0 pi0 marked this pull request as ready for review February 24, 2021 21:01
@pi0 pi0 merged commit 4d8077f into dev Feb 24, 2021
@pi0 pi0 deleted the feat/watchpack2 branch February 24, 2021 21:01
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants