Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): update hmr option for extract-css-chunks-webpack-plugin #8951

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Mar 8, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

Looks like extract-css-chunks-webpack-plugin changed options format in faceyspacey/extract-css-chunks-webpack-plugin@9daf720.

closes #5390

Checklist:

  • All new and existing tests are passing.

@danielroe danielroe requested a review from clarkdo March 8, 2021 10:30
@danielroe danielroe self-assigned this Mar 8, 2021
@clarkdo clarkdo merged commit 7841bd0 into dev Mar 8, 2021
@danielroe danielroe deleted the 5390-extract-css-hmr branch March 8, 2021 11:22
@pi0 pi0 mentioned this pull request Mar 9, 2021
This was referenced Mar 10, 2021
This was referenced Mar 15, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExtractCSS rule breaks HMR and SourceMaps in dev mode.
2 participants