fix: server docs #1180
Merged
fix: server docs #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove serverMiddleware from middleware folder in example
debs-obrien
requested review from
aytdm,
febrihidayan,
inouetakuya and
a team
as code owners
pi0
reviewed
Jan 20, 2021
| @@ -57,7 +57,7 @@ A Node.js server needs to be configured to execute your Vue.js application. | |||
|
|
|||
| You can extend the server with serverMiddleware and control routes with middleware. | |||
|
|
|||
| ```js{}[middleware/api/logger.js] | |||
| ```js{}[api/logger.js] | |||
There was a problem hiding this comment.
api directory is currently picked by CIs like vercel and also in the feature, it will be used for api routes. So i would suggest using server-middleware in nuxt2 examples to avoid more potential conflicts
debs-obrien
added a commit
that referenced
this pull request
Jan 20, 2021
This reverts commit 08c2b5c.
|
oops merged before I seen your comment. it seems on maintainers app reviews don't get shown in history and of course should have scrolled up on github and checked to see if someone had added review. will make new pr. sorry @pi0 and yeah makes sense |
pi0
pushed a commit
that referenced
this pull request
Jul 8, 2021
remove serverMiddleware from middleware folder in example
imgbot bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
remove serverMiddleware from middleware folder in example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove serverMiddleware from middleware folder in example