Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new module prepare mode for types #392

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 6, 2023

resolves nuxt/nuxt#22564

@silverbackdan
Copy link

Hi, I'm not sure where I'm missing a name argument but after trying these migration steps I get this error:

TypeError [ERR_MISSING_ARGS]: The "name" argument must be specified
    at new NodeError (node:internal/errors:405:5)
    at Performance.mark (node:internal/perf/performance:125:13)
    at normalizedModule (file:///Users/danielwest/.npm-packages/lib/node_modules/@nuxt/devtools/node_modules/@nuxt/kit/dist/index.mjs:169:30)
    at async installModule (file:///Users/danielwest/Documents/GitHub/_CWA/cwa-nuxt-3-module/node_modules/.pnpm/@nuxt+kit@3.6.0_rollup@3.25.1/node_modules/@nuxt/kit/dist/index.mjs:2409:95)
    at async initNuxt (file:///Users/danielwest/Documents/GitHub/_CWA/cwa-nuxt-3-module/node_modules/.pnpm/nuxt@3.6.0_@types+node@20.3.1_eslint@8.43.0_rollup@3.25.1_sass@1.63.6_typescript@5.1.3/node_modules/nuxt/dist/index.mjs:3164:7)
    at async loadNuxt (file:///Users/danielwest/Documents/GitHub/_CWA/cwa-nuxt-3-module/node_modules/.pnpm/nuxt@3.6.0_@types+node@20.3.1_eslint@8.43.0_rollup@3.25.1_sass@1.63.6_typescript@5.1.3/node_modules/nuxt/dist/index.mjs:3230:5)
    at async loadNuxt (file:///Users/danielwest/Documents/GitHub/_CWA/cwa-nuxt-3-module/node_modules/.pnpm/@nuxt+kit@3.6.0_rollup@2.79.1/node_modules/@nuxt/kit/dist/index.mjs:2537:19)
    at async Object.invoke (file:///Users/danielwest/Documents/GitHub/_CWA/cwa-nuxt-3-module/node_modules/.pnpm/nuxi@3.6.0/node_modules/nuxi/dist/chunks/prepare.mjs:31:18)
    at async runCommand (file:///Users/danielwest/Documents/GitHub/_CWA/cwa-nuxt-3-module/node_modules/.pnpm/nuxi@3.6.0/node_modules/nuxi/dist/index.mjs:10:3) {
  code: 'ERR_MISSING_ARGS'
}

I write this here as it is where the 3.6 release notes forward module authors to try this feature out by performing these steps.

@danielroe
Copy link
Member Author

What node version are you on?

@silverbackdan
Copy link

20.3.1

@danielroe danielroe marked this pull request as ready for review September 18, 2023 08:07
@danielroe danielroe merged commit 88de906 into module Sep 18, 2023
@danielroe danielroe deleted the feat/module-prepare branch September 18, 2023 08:07
This was referenced Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants