Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use buildDir option #596

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix: use buildDir option #596

merged 1 commit into from
Dec 2, 2023

Conversation

harlan-zw
Copy link
Contributor

The types for the setup() function provide a buildDir option, this isn't used.

const { resolve } = createResolver(import.meta.url)

await setup({
  rootDir: resolve('../fixtures/basic'),
  buildDir: resolve('./build'), // doesn't do anything
})

@danielroe danielroe merged commit 05dbe7f into main Dec 2, 2023
3 checks passed
@danielroe danielroe deleted the fix/use-build-dir branch December 2, 2023 07:17
@danielroe danielroe mentioned this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants