ci: remove caching of Playwright browsers #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Mar 16, 2024
| @@ -13,8 +13,6 @@ env: | |||
| # 7 GiB by default on GitHub, setting to 6 GiB | |||
| # https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources | |||
| NODE_OPTIONS: --max-old-space-size=6144 | |||
| # install playwright binary manually (because pnpm only runs install script once) | |||
| PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: "1" | |||
There was a problem hiding this comment.
drive-by: Playwright does not install browsers as part of install script since v1.38.
9 tasks
mxschmitt
force-pushed
the
devops/remove-caching-browsers
branch
from
05794ba
to
163553c
Compare
mxschmitt
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching the Playwright browsers is a concept which often leads to confusion, since yes, browsers can be cached, but they also rely on operating system dependencies, which can't be cached.
This might work for Chromium, since GitHub Action environments have all the OS dependencies already pre-installed for running Chromium, but for WebKit / Firefox this won't work (launch will yell with dependencies missing error).
So having this extra complexity for saving 1-5 seconds on a process (downloading the browsers) which only takes 5 seconds seems not worth it (restoring the cache takes a similar duration)
See also here: https://playwright.dev/docs/ci#caching-browsers