Skip to content

Commit

Permalink
fix(Notification): add roles for accessibility (#724)
Browse files Browse the repository at this point in the history
  • Loading branch information
MuhammadM1998 committed Oct 18, 2023
1 parent a8279d1 commit 40f3b16
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion src/runtime/components/overlays/Notification.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
<template>
<Transition appear v-bind="ui.transition">
<div :class="wrapperClass" v-bind="attrs" @mouseover="onMouseover" @mouseleave="onMouseleave">
<div
:class="wrapperClass"
role="status"
v-bind="attrs"
@mouseover="onMouseover"
@mouseleave="onMouseleave"
>
<div :class="[ui.container, ui.rounded, ui.ring]">
<div :class="ui.padding">
<div class="flex gap-3" :class="{ 'items-start': description || $slots.description, 'items-center': !description && !$slots.description }">
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/components/overlays/Notifications.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<div :class="wrapperClass" v-bind="attrs">
<div :class="wrapperClass" role="region" v-bind="attrs">
<div v-if="notifications.length" :class="ui.container">
<div v-for="notification of notifications" :key="notification.id">
<UNotification
Expand Down

1 comment on commit 40f3b16

@vercel
Copy link

@vercel vercel bot commented on 40f3b16 Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

ui – ./

ui-git-dev-nuxt-js.vercel.app
ui-nuxt-js.vercel.app
ui.nuxt.com

Please sign in to comment.