Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Textarea): add maxrows prop to restrict autoresize #1302

Merged
merged 4 commits into from
Feb 5, 2024
Merged

feat(Textarea): add maxrows prop to restrict autoresize #1302

merged 4 commits into from
Feb 5, 2024

Conversation

pedraal
Copy link
Contributor

@pedraal pedraal commented Jan 31, 2024

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In the current state, Textarea component with the autoresize prop will grow infinitely.
This pull request aims to add a new prop letting developers to define a maximum number of rows a Textarea can grow.
If set to 0 (which is also the default value), it will preserve the current autoresize behavior.

I didn't manage to start the local development environment for the docs because of the required nuxt ui pro license so I didn't check if my changes to ui/docs/content/2.components/textarea.md are correct.

feat.Textarea.add.maxrows.prop.to.restrict.autoresize.mov

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
ui βœ… Ready (Inspect) Visit Preview Feb 5, 2024 2:48pm

@benjamincanac
Copy link
Member

@pedraal What happened when you started the docs? It should run in dev even if you don't have the license which is only required on build.

@pedraal
Copy link
Contributor Author

pedraal commented Feb 1, 2024

@benjamincanac Oh I'm sorry, I've miss interpreted the message in the terminal as the dev docs server was taking a long time to start 🀦

I works now, but it looks like my changes to ui/docs/content/2.components/textarea.md didn't reflect into the actual docs. I've probably missed something I'll give it another look this evening. Sorry for the bother (it's my first time contributing to open source)

Copy link
Member

You need to use the dropdown on the top left to switch to nuxt/ui-edge 😊

@pedraal
Copy link
Contributor Author

pedraal commented Feb 1, 2024

Ok got it thank you πŸ˜ƒ
Here there anything I can do to check why the deployment failed ? Anything I can do to make this PR better ? Or is it ok like this and I can wait for a review ?

@benjamincanac benjamincanac merged commit f643e7b into nuxt:dev Feb 5, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks @pedraal! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants