-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Textarea): add maxrows
prop to restrict autoresize
#1302
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
@pedraal What happened when you started the docs? It should run in dev even if you don't have the license which is only required on build. |
@benjamincanac Oh I'm sorry, I've miss interpreted the message in the terminal as the dev docs server was taking a long time to start π€¦ I works now, but it looks like my changes to |
You need to use the dropdown on the top left to switch to |
Ok got it thank you π |
Thanks @pedraal! π |
β Type of change
π Description
In the current state,
Textarea
component with theautoresize
prop will grow infinitely.This pull request aims to add a new prop letting developers to define a maximum number of rows a
Textarea
can grow.If set to 0 (which is also the default value), it will preserve the current
autoresize
behavior.I didn't manage to start the local development environment for the docs because of the required nuxt ui pro license so I didn't check if my changes to
ui/docs/content/2.components/textarea.md
are correct.feat.Textarea.add.maxrows.prop.to.restrict.autoresize.mov
π Checklist