Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nuxt-shiki for syntax highlighting #1361

Closed
pi0 opened this issue Feb 14, 2024 · 5 comments
Closed

Use nuxt-shiki for syntax highlighting #1361

pi0 opened this issue Feb 14, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Feb 14, 2024

Description

Hi. Today I learned (unjs/undocs#45) that there are several places Shiki is being integrated into Nuxt.

I made a quick draft of nuxt-shiki module to make it more standard from one place.

I would love to hear what would be needed / what features are missing to make this happen.

(mdc discussion nuxt-modules/mdc#148)

Copy link
Member

Closing this as the docs heavily rely on @nuxt/content and @nuxtjs/mdc anyway.

@benjamincanac benjamincanac closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@pi0
Copy link
Member Author

pi0 commented Mar 20, 2024

@benjamincanac This is critical for me + undocs. I hope collabration from @farnabaz too otherwise i need to make a patch for @nuxt/ui to only fix this, neither can support either of projects on nitro side :(

@farnabaz
Copy link
Member

Seems like we have to adopt nuxt-shiki and there is no place to discuss it and understand why it should be separated and cannot implement within MDC module. (I give up)

@pi0 Do you mind making it possible to get Shiki instance outside of Nuxt Context in nuxt-shiki. Otherwise, it is breaking change for MDC and Content module.

Copy link
Member

benjamincanac commented Mar 20, 2024

@pi0 Not sure to understand the relation with @nuxt/ui here. There is no dependency to either content, mdc or even shiki.

@pi0
Copy link
Member Author

pi0 commented Mar 20, 2024

(off topic) @farnabaz Regarding mdc module:


@benjamincanac fair enough i will followup for content side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants