Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Slideover): handle translate in RTL mode #1259

Merged
merged 1 commit into from Jan 22, 2024
Merged

fix(Slideover): handle translate in RTL mode #1259

merged 1 commit into from Jan 22, 2024

Conversation

FADL285
Copy link
Contributor

@FADL285 FADL285 commented Jan 19, 2024 •
edited

Update the Slideover translate config to solve the translate animation directions in RTL.

🔗 Linked issue

Resolves #1258

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added RTL translate styles for the Slideover component to handle translation in rtl direction

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@FADL285
fix(Slideover): Update Slideover translate directions in RTL mode
ade4867 
Update the Slideover translate config to solve the translate animation directions in RTL.
@vercel Vercel
Copy link

vercel bot commented Jan 19, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Jan 19, 2024 8:16pm

@benjamincanac benjamincanac changed the title fix #1258 (Slideover) - Update Slideover translate directions in RTL mode fix(Slideover): handle translate directions in RTL mode Jan 22, 2024
@benjamincanac benjamincanac changed the title fix(Slideover): handle translate directions in RTL mode fix(Slideover): handle translate in RTL mode Jan 22, 2024
@benjamincanac benjamincanac merged commit ea58c88 into nuxt:dev Jan 22, 2024
1 check passed
@benjamincanac
Copy link
Member

Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SideOver Component Animation Issue in RTL Mode
2 participants
@FADL285 @benjamincanac