Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Pagination): allow using links for pagination buttons #1682

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

noook
Copy link
Collaborator

@noook noook commented Apr 16, 2024

πŸ”— Linked issue

Resolves #1478

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This change allows buttons in the pagination to become links, and be detected by crawlers

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac
Copy link
Member

@noook Your issue with page reload is because there is no page inside the playground so vue-router is disabled. I've updated it so you can take a look 😊

@noook
Copy link
Collaborator Author

noook commented Apr 18, 2024

All good then ! Should I keep the <NuxtPage /> in the playground ? I'll remove the test code anyway

Copy link
Member

I'd say you can revert it! We mostly use it for reproductions at this time.

@benjamincanac
Copy link
Member

Maybe we should add a note in the docs about this?

@benjamincanac benjamincanac merged commit 8d9d973 into nuxt:dev Apr 18, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks @noook! 😊

@noook noook deleted the feat/pagination-links branch April 18, 2024 10:45
@Youhan
Copy link
Contributor

Youhan commented Apr 18, 2024

Thanks guys πŸ™Œ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pagination]: Option to generate <a> instead of <button>
3 participants