Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): enable sorting for nested column keys #835

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

mwohlan
Copy link
Contributor

@mwohlan mwohlan commented Oct 19, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

While I was using the Table component I noticed that sorting did not work on nested column keys. I.e. when
defining a column like this:

{
  key: 'creditor.name',
  label: 'Creditor',
  sortable: true,
}

Since the get function is already being imported, I made this small change.

Edit: Forgot to mention performance. This definitely affects performance to some degree but could possibly
be negligible in practice.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
ui βœ… Ready (Inspect) Visit Preview Oct 19, 2023 6:15am

@benjamincanac
Copy link
Member

Indeed we completely missed that, thank you 😊

@benjamincanac benjamincanac changed the title feat(Table): enable sorting for nested column keys fix(Table): enable sorting for nested column keys Oct 19, 2023
@benjamincanac benjamincanac merged commit b4f7b03 into nuxt:dev Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants