fix(ButtonGroup): handle components with children #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
connerblanton
changed the title
benjamincanac
changed the title
There was a problem hiding this comment.
Any idea on the preview why the size and orientation props are not reactive? It does the same when using the component.
https://ui-6r8tp8i74-nuxt-js.vercel.app/dev/elements/button#group
benjamincanac
approved these changes
Nov 20, 2023
|
No problem at all! Thanks for the advice on the other PR and pointing me in the direction of Anthony's solution. Really made me rethink the problem and I got to learn from it all 😊 |
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#256
❓ Type of change
📚 Description
Trying another shot at this one 😀 Using provide/inject through the new
useButtonGroupcomposable. Using Vue'sgetCurrentInstanceso that a child can figure out it's position in theButtonGroupand adjust it's roundness accordingly.Added this functionality to the
Badge,Button,Input,Select, andSelectMenucomponentsResolves #256
📝 Checklist