Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

feat: vite 2.3 #138

Merged
merged 5 commits into from
May 25, 2021
Merged

feat: vite 2.3 #138

merged 5 commits into from
May 25, 2021

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 12, 2021

resolves #135

  • Use new cacheDir option (replacing plugin)
  • Set server.fsServer.root option to allow serving from rootDir rather than buildDir (.nuxt)

Current issues:

  • The request url "/@id/defaultexport:<rootDir>/.nuxt/components/plugin.js" is outside of vite dev server root "<rootDir>"
    • [vite] @id to be handled or isolation checked after resolveId hook?
    • alternative: change defaultexport implementation?
    • alternative: start enforcing default export by nuxt plugins? (even if they don't need. this reduces module support but makes it easier for us)
  • The request URL "<repoDir>/node_modules/ufo/dist/index.mjs" is outside of vite dev server root "<rootDir>". (repo is not a workspace but contains sub directory)
    • [vite] Support root as array? (to include nuxt.options.modulesDir[])
    • alternative: lookup for lockfile instead?

Update: fsServe isolation is disabled as a workaround

pi0 added a commit that referenced this pull request May 12, 2021
@pi0 pi0 mentioned this pull request Jan 19, 2023
@pi0 pi0 marked this pull request as ready for review May 25, 2021 12:54
@pi0 pi0 merged commit 3a045d9 into main May 25, 2021
@pi0 pi0 deleted the vite2_3 branch May 25, 2021 12:55
@pi0 pi0 restored the vite2_3 branch May 25, 2021 12:55
@pi0 pi0 deleted the vite2_3 branch May 25, 2021 12:55
Copy link

@irene459 irene459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been hacked delete everything this monster has created on my account please

Copy link

@irene459 irene459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been hacked delete everything this monster has created on my account please

src/client.ts Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Vite 2.3
3 participants