chore: lint & fix test

nuxt · Sep 12, 2019 · ae98f65 · ae98f65
1 parent c344d60
commit ae98f65
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/src/shared/getComponentOption.js b/src/shared/getComponentOption.js
@@ -1,4 +1,4 @@
-import { isFunction, isObject } from '../utils/is-type'
+import { isObject } from '../utils/is-type'
 import { defaultInfo } from './constants'
 import { merge } from './merge'
 import { inMetaInfoBranch } from './meta-helpers'

diff --git a/test/components/changed.vue b/test/components/changed.vue
@@ -18,17 +18,13 @@ export default {
   },
   metaInfo() {
     return {
-      changed: this._changed
+      changed: this.changed.bind(this)
     }
   },
   data() {
     return {
-      childVisible: false,
-      _changed: () => {}
+      childVisible: false
     }
-  },
-  mounted() {
-    this._changed = this.changed.bind(this)
-  }
+f  }
 }
 </script>
diff --git a/test/unit/getComponentOptions.test.js b/test/unit/getComponentOptions.test.js
@@ -20,13 +20,19 @@ describe('getComponentOption', () => {
     expect(mergedOption.foo).toEqual('bar')
   })
 
-  test('calls a function option, injecting the component as context', () => {
+  test('calls a function as computed prop, injecting the component as context', () => {
     const component = new Vue({
       name: 'Foobar',
       someFunc () {
-        return { opt: this.$options.name }
+        return { opt: this.name }
+      },
+      computed: {
+        $metaInfo () {
+          return this.$options.someFunc()
+        }
       }
     })
+
     const mergedOption = getComponentOption({ keyName: 'someFunc' }, component)
     // TODO: Should this be foobar or Foobar
     expect(mergedOption.opt).toBeDefined()