-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting "document is not defined" after upgrading to 0.5.6 #82
Comments
Same here. Here's my error using
For now I've reverted back to |
^^ having the same issue with an upgrade to |
Are you guys also using |
@rhwilr exact same problem with |
Yes, we are using vuex-router-sync as well. |
Having the same issue, too, with |
Maybe i'm wrong, but i have the same problem both in the 0.5.5 and 0.5.6 |
I submitted a PR last week which fixes the issue for me. #84 |
Got the same error, had to downgrade. Kinda strange that a breaking change hasn't been addressed by the repo owner in two weeks :-/. |
@MaximilianLloyd maybe busy or holidays 💃 |
@rhwilr The interesting thing is that when I made that pull request, it worked fine. I didn't think destroyed() would even be called on the server. I'm not sure why this issue didn't pop up before, because it definitely is now. Sorry everyone for causing the havoc. |
@rhwilr , hmm, it works for me(0.5.6), thanks |
This issue is still present, and I've confirmed the fix from @rhwilr solves the issue:
before batchUpdate in destroyed |
I am not using I notice |
Should be fixed with |
Im still seeing this problem with vue-meta@1.0.0 and above. Using SSR.
|
Can you create a step to reproduce this issue @nilsi ? |
What I did was to clone this repo: I installed vue-meta with:
And added imported Meta in
Then when I try to access the page Im getting this error |
I'm experiencing this issue with version 1.0.4, just create a pull request with a fix that worked for me: #101 |
I'm also getting this error when running |
I've managed to fix this issue in my own project. The main idea is to prevent the Vue instance from mounting on the server, by removing the el property from the Vue object on the server-side, then mount the Vue instance manually client side
import Vue from 'vue';
// Meteor Tracker integration
import VueMeteorTracker from 'vue-meteor-tracker'
Vue.use(VueMeteorTracker)
import App from './ui/App.vue'
import router from './router'
function createApp () {
return {
app: new Vue({
// el: '#app', <= REMOVE THIS
router,
...App,
}),
router,
}
}
export default createApp;
import { Meteor } from 'meteor/meteor'
import CreateApp from './app'
Meteor.startup(() => {
CreateApp().app.$mount('#app');
}) You can test this on my vue-meteor-boilerplate |
We've been using vue-meta with SSR on 0.5.5, but after upgrading to 0.5.6 we started getting the following errors on the server:
The text was updated successfully, but these errors were encountered: