Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensively exercise each function in the test suite #56

Open
manopapad opened this issue Jul 29, 2021 · 0 comments
Open

Comprehensively exercise each function in the test suite #56

manopapad opened this issue Jul 29, 2021 · 0 comments
Labels

Comments

@manopapad
Copy link
Contributor

manopapad commented Jul 29, 2021

Each supported function should be fully exercised in the test suite, e.g.:

  • all datatypes supported for the operation
  • all supported options
  • using a where array, if supported by the operation
  • all broadcasting modes
  • all cases of implicit up-casting (e.g. adding an integer and a real array) -- we should test at least every combination of an integer, a floating point and a complex array
  • other cases of store transformations on inputs (e.g. slice, transpose)
  • all array dimensions, up to the max number of dimensions that Legate was compiled for
  • passing existing arrays as outputs

To keep things sane, each of the above parameters can be tested in isolation.

To cover an arbitrary amount of dimensions it will be necessary to programmatically generate inputs, e.g. see https://github.com/nv-legate/legate.numpy/blob/896f4fd9b32db445da6cdabf7b78d523fca96936/tests/binary_op_broadcast.py and https://github.com/nv-legate/legate.numpy/blob/067a541905bf3bfc8d3727c6e1fe97a4855729b9/tests/intra_array_copy.py.

The NumPy test suite may be a good starting point, see #22.

fduguet-nv pushed a commit to fduguet-nv/cunumeric that referenced this issue Mar 29, 2022
This change should prevent CI from running on forks.

The issue with running on forks is that the CI always generates an error since no suitable runners are available.

Co-authored-by: Marcin Zalewski <mzalewski@nvidia.com>
manopapad pushed a commit to manopapad/cunumeric that referenced this issue Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant