Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust contrib instructions for pip install location #141

Merged
2 commits merged into from
Jul 13, 2022
Merged

Adjust contrib instructions for pip install location #141

2 commits merged into from
Jul 13, 2022

Conversation

pdmack
Copy link
Contributor

@pdmack pdmack commented Jul 13, 2022

pip install from the build/python dir, not $SRF_HOME/python

Not sure if we need to even mention SRF_PYTHON_INPLACE_BUILD var

@mdemoret-nv

pip install from the build/python dir not $SRF_ROOT

Not sure if we need to even mention SRF_PYTHON_INPLACE_BUILD var
@pdmack pdmack requested a review from a team as a code owner July 13, 2022 15:56
Same change as for contrib guide (pip dir)
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv mdemoret-nv added doc Improvements or additions to documentation non-breaking Non-breaking change labels Jul 13, 2022
@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit 96b0a9c into nv-morpheus:branch-22.08 Jul 13, 2022
@pdmack pdmack deleted the patch-1 branch July 13, 2022 20:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants