Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python debug detection for new version of debugpy #322

Merged

Conversation

mdemoret-nv
Copy link
Contributor

Description

Looks like the library debugpy was updated to use cython instead of python. This broke our system of detecting when a debugger is attached.

This PR just changes the detection system to use str(sys.gettrace()) instead of sys.gettrace().__module__ since __module__ is no longer set. The effect will still be the same.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Apr 27, 2023
@mdemoret-nv mdemoret-nv requested review from a team as code owners April 27, 2023 19:27
@cwharris
Copy link
Contributor

What's with init.sh changing?

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #322 (4f4f7cd) into branch-23.07 (92aa21a) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-23.07     #322   +/-   ##
=============================================
  Coverage         73.24%   73.24%           
=============================================
  Files               390      390           
  Lines             13380    13380           
  Branches           1010     1009    -1     
=============================================
  Hits               9800     9800           
  Misses             3580     3580           
Flag Coverage Δ
cpp 69.07% <0.00%> (ø)
py 42.22% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/mrc/_pymrc/src/system.cpp 64.10% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92aa21a...4f4f7cd. Read the comment docs.

@mdemoret-nv
Copy link
Contributor Author

mdemoret-nv commented Apr 27, 2023

What's with init.sh changing?

@cwharris It was missing chmod +x in the file permissions so you got an error every time you tried to build the dev container.

@mdemoret-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5b6c627 into nv-morpheus:branch-23.07 Apr 27, 2023
@mdemoret-nv mdemoret-nv deleted the mdd_fix-debug-python branch April 27, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants