Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few minor type-o's in comments #332

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jun 20, 2023

Description

  • Replace references to TaggedManager with TaggedIssuer
  • Ran across these while reading up on control plane

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner June 20, 2023 18:20
@dagardner-nv dagardner-nv self-assigned this Jun 20, 2023
@dagardner-nv dagardner-nv added doc Improvements or additions to documentation non-breaking Non-breaking change priority 2 labels Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #332 (758052a) into branch-23.07 (a823580) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-23.07     #332   +/-   ##
=============================================
  Coverage         73.24%   73.25%           
=============================================
  Files               390      390           
  Lines             13382    13382           
  Branches           1009     1009           
=============================================
+ Hits               9802     9803    +1     
+ Misses             3580     3579    -1     
Flag Coverage Δ
cpp 69.23% <ø> (+<0.01%) ⬆️
py 42.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/src/internal/control_plane/server.cpp 41.26% <ø> (ø)
...rc/internal/control_plane/server/tagged_issuer.hpp 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a823580...758052a. Read the comment docs.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0d0ab70 into nv-morpheus:branch-23.07 Jun 20, 2023
11 checks passed
@dagardner-nv dagardner-nv deleted the david-typo branch June 20, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants