Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt patched pybind11 #364

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Aug 18, 2023

Description

  • Adopt patched pybind11
  • Update versions of boost & libhwloc to work-around clang CI issue
  • A test for this bug exists in Morpheus, but is difficult to reproduce in MRC. A MRC based test coming soon.

fixes #362

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner August 18, 2023 14:50
@dagardner-nv dagardner-nv self-assigned this Aug 18, 2023
@dagardner-nv dagardner-nv added non-breaking Non-breaking change priority 0 bug Something isn't working labels Aug 18, 2023
…s different builds of llvm packages to fix CI
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #364 (8be5e75) into branch-23.11 (9b47924) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.11     #364      +/-   ##
================================================
+ Coverage         73.11%   73.14%   +0.02%     
================================================
  Files               382      382              
  Lines             13403    13403              
  Branches           1010     1011       +1     
================================================
+ Hits               9800     9804       +4     
+ Misses             3603     3599       -4     
Flag Coverage Δ
cpp 69.08% <ø> (+0.03%) ⬆️
py 42.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b47924...8be5e75. Read the comment docs.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9ae280a into nv-morpheus:branch-23.11 Aug 18, 2023
14 checks passed
@dagardner-nv dagardner-nv deleted the david-adpot-patched-pybind11 branch August 18, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Python thread finalizer can cause thread-local storage to be cleared prematurely in some situations
2 participants