Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boost versions to match version used in dev env #404

Merged

Conversation

dagardner-nv
Copy link
Contributor

Description

PR #391 updated the version of boost, but I forgot to update the version in the package's yaml.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner October 3, 2023 19:32
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change conda-build Enables running the conda-build step on a PR labels Oct 3, 2023
@dagardner-nv dagardner-nv self-assigned this Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #404 (fc1f8d9) into branch-23.11 (ba483b1) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.11     #404      +/-   ##
================================================
- Coverage         73.62%   73.59%   -0.04%     
================================================
  Files               385      385              
  Lines             13613    13613              
  Branches           1029     1028       -1     
================================================
- Hits              10023    10018       -5     
- Misses             3590     3595       +5     
Flag Coverage Δ
cpp 69.67% <ø> (-0.04%) ⬇️
py 42.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba483b1...fc1f8d9. Read the comment docs.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 34bacd1 into nv-morpheus:branch-23.11 Oct 9, 2023
14 checks passed
@dagardner-nv dagardner-nv deleted the david-fix-boost-conda-pkg branch October 9, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conda-build Enables running the conda-build step on a PR non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants