Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a separate CI workflow for branch-YY.MM & main branches #466

Open
wants to merge 9 commits into
base: branch-24.06
Choose a base branch
from

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Apr 5, 2024

Description

  • Prevents an issue where creating a release PR triggers two CI jobs:

    1. For the pull-request/NNN branch created by the PR
    2. For the push to branch-YY.MM
  • Unfortunately the changes for branch-YY.MM and main can't be tested until after the changes are merged.

Closes #459

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Apr 5, 2024
@dagardner-nv dagardner-nv self-assigned this Apr 5, 2024
@dagardner-nv dagardner-nv requested review from a team as code owners April 5, 2024 18:52
@dagardner-nv dagardner-nv marked this pull request as draft April 5, 2024 18:52
@dagardner-nv dagardner-nv changed the base branch from branch-24.03 to branch-24.06 April 5, 2024 18:52
@dagardner-nv dagardner-nv added the conda-build Enables running the conda-build step on a PR label Apr 8, 2024
@dagardner-nv dagardner-nv marked this pull request as ready for review April 8, 2024 23:47
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make a spreadsheet of the CI steps and what should run in each scenario and revisit this PR

.github/workflows/build_branch.yaml Outdated Show resolved Hide resolved
@dagardner-nv dagardner-nv marked this pull request as draft April 10, 2024 20:31
@dagardner-nv dagardner-nv marked this pull request as ready for review June 18, 2024 15:26
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (7b599a3) to head (c61ef52).
Report is 1 commits behind head on branch-24.06.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.06     #466      +/-   ##
================================================
- Coverage         74.08%   74.06%   -0.03%     
================================================
  Files               403      403              
  Lines             14401    14401              
  Branches           1132     1132              
================================================
- Hits              10669    10666       -3     
- Misses             3732     3735       +3     
Flag Coverage Δ
cpp 70.82% <ø> (-0.03%) ⬇️
py 41.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b599a3...c61ef52. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conda-build Enables running the conda-build step on a PR non-breaking Non-breaking change
Projects
Status: Review - Changes Requested
Development

Successfully merging this pull request may close these issues.

[BUG]: Skip shared style/prinfo workflows for main & branch-YY.MM branches
3 participants