Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub actions to check the SHAs and validity of URLs #112

Closed
seanbudd opened this issue Mar 6, 2023 · 3 comments · Fixed by #575
Closed

Use GitHub actions to check the SHAs and validity of URLs #112

seanbudd opened this issue Mar 6, 2023 · 3 comments · Fixed by #575
Labels
enhancement New feature or request

Comments

@seanbudd
Copy link
Member

seanbudd commented Mar 6, 2023

What happens if an URL is not available anymore? E.g. deleting a GitHub release by mistake.

From the add-on author point of view, I guess that this version should be revoked and a new should be made. But what if the author do not revoke it? May an add-on be revoked due to a permanently broken link (or a modified SHA)?

Originally posted by @CyrilleB79 in #109 (comment)

A GitHub action should check the SHAs and ensure the URLs work for all versions of add-ons hosted in the add-on store.

@CyrilleB79
Copy link
Contributor

Also, if possible, the check should be robust to temporary URL unavailability in order to avoid revoking add-ons by mistake.

Maybe there should not be auto-revokation but only a mail sent to NVAccess or add-on store maintenance team so that the situation is handled by humans.

@XLTechie
Copy link
Contributor

XLTechie commented Mar 6, 2023 via email

@seanbudd
Copy link
Member Author

seanbudd commented Mar 7, 2023

It's probably also worth running full schema validation on all add-ons retrospectively to pick up any add-ons which were merged before certain schema requirements were made.

@seanbudd seanbudd added the enhancement New feature or request label Mar 23, 2023
seanbudd added a commit that referenced this issue May 1, 2023
Closes: #112

Integrates changes in nvaccess/addon-datastore-validation#30

This PR adds a GitHub action to validate all add-on submissions.
This is run once a month and can be run manually.
This also updates some submissions to fix validation issues.

Validating all submissions has been tested with this action run.
Validating a regular add-on submission has been tested with this action run.

Changes:

an outdated submission of sayProductNameAndVersion was marked as legacy due to an invalid API version in the manifest
an outdated submission of searchWith was marked as legacy due to the JSON data having a differently cased addonId than the manifest
unigrams SHA was updated. There has been two releases and submissions of unigram with the same semantic version. 2.0 and 2.0.0. It is likely this is the cause of the SHA issue.
an outdated submission of winMag was deleted. This is due to the github release being removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants