Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Register add-on in translation system]: nvdaRd #86

Closed
1 task done
nvdaes opened this issue Mar 12, 2023 · 4 comments
Closed
1 task done

[Register add-on in translation system]: nvdaRd #86

nvdaes opened this issue Mar 12, 2023 · 4 comments
Assignees
@seanbudd
Labels
enhancement New feature or request

Comments

@nvdaes
Copy link
Sponsor Collaborator

nvdaes commented Mar 12, 2023

Add-on name

nvdaRd

Add-on maintainer

@LeonarddeR

Stable branch

  • Stable branch exists in add-on repo
@nvdaes nvdaes added the enhancement New feature or request label Mar 12, 2023
@nvdaes
Copy link
Sponsor Collaborator Author

nvdaes commented Mar 12, 2023

@seanbudd The GitHub workflow for this needs to be updated. It's quite old and now, to create a comment for an issue, we need to address this change:

github.issues.createComment in V4 becomes github.rest.issues.createComment in V5
Please see GitHub Script readme

When this is done, we can close and reopen this issue so that the comment reflecting that this is ready for registration is added.

@seanbudd seanbudd self-assigned this Mar 23, 2023
@seanbudd seanbudd mentioned this issue Mar 24, 2023
Merged
seanbudd added a commit that referenced this issue Mar 24, 2023
@seanbudd
Update github comment action, docs (#87)
9afa934 
As per comment here:
#86 (comment)

The github action we were using is deprecated. This has been updated.

The documentation has also been to reference the new add-on repo, instead of the legacy one
@seanbudd seanbudd reopened this Mar 24, 2023
@github-actions
Copy link

The add-on and pot files were built from stable branch

@seanbudd
Copy link
Member

seanbudd commented Mar 26, 2023 •
edited
Loading

This add-on has now been registered

@LeonarddeR
Copy link

Thanks @seanbudd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanbudd seanbudd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LeonarddeR @seanbudd @nvdaes