New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not Running in Fish Shell #807
Comments
I've tried the fixes in #717 and am still having the same issue. |
I'm having this issue as well, I'm on Mac OS 10.13.4 with The Fuck 3.26 using Python 3.6.5 |
I managed to reproduce this on a fresh installation (Docker). I'll investigate this ASAP. Thank you for reporting. |
Fix is on its way. In the meantime, I guess you can use this temporary fix: alias fish_key_reader /usr/local/bin/fish_key_reader Please let me know if it works for you. Edit: if the temporary fix doesn't work, try redeclaring with alias foo echo # declare like this
alias foo=echo # instead of this ps.: maybe you'd want to clear thefuck's cache with |
The temporary fix works for me after restarting my shell. Thanks! |
I have this issue, but I don't think the fix works for me, although I may not be applying it right. I tried adding it to the ~/.config/fish/functions/fuck.fish function, as well as running it separately, and the error was still the same. |
@DmitriK I'm sorry to read that. Maybe you stumbled over another issue? Can you please post the output with the error with |
Sure, output follows. I know thefuck was working very recently, as I had run into #730, and everything worked when I fixed the environment variable mentioned in that issue. Something about my setup changed recently to cause this, but I'm not sure exactly what. For what it's worth, I'm on ArchLinux
|
I did some brute force debugging by adding some logging directly to the fish.py file where the exception occurs. On my system, 'alias_out' is an empty byte string, presumably because I don't generate aliases elsewhere, and a fresh instance of fish is spawned by Popen. Anyway, I directly applied the diff in the PR to my copy, and that does fix the issue for me since the split length is checked explicitly. I'll keep the patch in there until an official package gets out. |
Hi there! I'm hitting something similar too. The alias fish_key_reader fix doesn't seem to work for me. Defined with a space. No other aliases exist. Fish 2.7.1 on MacOS X 10.13.4, using thefuck --HEAD from Homebrew. Output attached, including thefuck debug stuff. Thanks a million for thefuck btw! Please let me know how I can help. |
I grabbed fish.py from commit dba7a8d and dropped it in /usr/local/Cellar/thefuck/HEAD-97f2d74/libexec/lib/python3.6/site-packages/thefuck/shells :) Everything is fine now. Thanks!! |
Will this be released (and published to homebrew) soon? |
@jrr the fix is included in 3.27, should be available in homebrew soon |
The output of
thefuck --version
(something likeThe Fuck 3.1 using Python 3.5.0
):The Fuck 3.26 using Python 3.6.5
Your shell and its version (
bash
,zsh
, Windows PowerShell, etc.):Fish v2.7.1 (works fine in Bash)
Your system (Debian 7, ArchLinux, Windows, etc.):
macOS 10.13.5 Beta (17F45c)
How to reproduce the bug:
Run 'fuck' command after entering any incorrect command in Fish shell.
The output of The Fuck with
THEFUCK_DEBUG=true
exported (typically executeexport THEFUCK_DEBUG=true
in your shell before The Fuck):If the bug only appears with a specific application, the output of that application and its version:
N/A
Anything else you think is relevant:
N/A
The text was updated successfully, but these errors were encountered: