Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add heroku_multiple_apps rule #729

Merged
merged 3 commits into from Nov 9, 2017
Merged

Add heroku_multiple_apps rule #729

merged 3 commits into from Nov 9, 2017

Conversation

josephfrazier
Copy link
Collaborator

Closes #728

scorphus
scorphus reviewed Nov 9, 2017
View reviewed changes
Copy link
Collaborator

@scorphus scorphus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

The three commits are correlated to one another. Do you agree? What would you say If I suggested squashing them? We can always use GitHub's feature to do so, when it makes sense.

Good job as a whole!

@josephfrazier josephfrazier merged commit 10ac1a3 into nvbn:master Nov 9, 2017
@josephfrazier
Copy link
Collaborator Author

Thanks for the review @scorphus! I was also thinking they should be squashed together, so I went ahead and did it just now :)

@josephfrazier josephfrazier deleted the heroku-multiple-apps branch March 6, 2018 16:08
riley-martine pushed a commit to riley-martine/thefuck that referenced this pull request Dec 7, 2023
@josephfrazier
nvbn#728: Add heroku_multiple_apps rule (nvbn#729)
53e4b32 
Closes nvbn#728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scorphus scorphus scorphus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josephfrazier @scorphus