Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation failed when npm is not installed #5

Closed
vladimir-low opened this issue Dec 24, 2015 · 1 comment
Closed

Installation failed when npm is not installed #5

vladimir-low opened this issue Dec 24, 2015 · 1 comment

Comments

@vladimir-low
Copy link

There is no way to install Profiler or dependencies via make when npm is missing in the system.

Steps to reproduce:

make deps_install
make install

Expected result:

All required dependencies are installed. Profiler are installed successfully.

Actual result:

"npm install
make: npm: Command not found
make: *** [deps_install] Error 127"

Possible solution:

Verify/Install npm at the very first step. Otherwise, document it in Prerequisites section.

Consider include the following into Makefile. But need to keep it cross-platform somehow:
packages:
[ -z dpkg -l | grep libx11-dev ] && sudo apt-get install libx11-dev
.PHONY: packages

@nvdv
Copy link
Owner

nvdv commented Dec 25, 2015

Thanks for reporting!

Installing npm during make install is pretty tricky, since there are many platforms and each one has several ways to do it properly.

I'll fix README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants