Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix iOS #6

Merged
merged 1 commit into from
Apr 23, 2024
Merged

ci: Fix iOS #6

merged 1 commit into from
Apr 23, 2024

Conversation

Soap-141
Copy link
Contributor

@Soap-141 Soap-141 commented Apr 23, 2024

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

Fixed an issue introduced by having extra packages that bring Pods. The specific Pod was for the new Apple Privacy Policy manifest and apparently required to be signed.

Fixed it by making the signing of bundle resource pods not required.

This is a workaround (Podfile script) used by many people online.

See CocoaPods/CocoaPods#11402 for more details.

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@Soap-141 Soap-141 marked this pull request as ready for review April 23, 2024 20:42
@Soap-141 Soap-141 merged commit 27bbfdf into main Apr 23, 2024
14 checks passed
@Soap-141 Soap-141 deleted the dev/thla/ci-fix-ios branch April 23, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants