Dev/bgy/add latlong tags #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Adds setLocationShared(bool) to the Unity proxy
* Specific when com.google.firebase:firebase-auth:15.1.0 is used the following error would throw - java.lang.IllegalArgumentException: Given String is empty or null - at com.google.android.gms.common.internal.Preconditions.checkNotEmpty(Unknown Source) - at com.google.firebase.auth.api.internal.zzcq.<init>(Unknown Source) - ... - at com.google.firebase.FirebaseApp.initializeApp(Unknown Source) - at com.onesignal.PushRegistratorFCM.initFirebaseApp(PushRegistratorFCM.java:64)
Unity Proxy setLocationShared
• Fixes a crash where the generateJsonDiff() method of the currentUserState property in UserStateSynchronizer is called before the currentUserState is initialized, by adding a synchronization step to the initUserState() method • Adds a check to make sure the user state is initialized before internalSyncUserState() attempts to access it.
Synchronize State
• The GoogleAPIClient instance in LocationGMS (accessed through a proxy via reflection) was being accessed before it was being connected due to a race condition • Introduces synchronization to ensure access to the instance only occurs after it is initialized & connected.
• Adds synchronization to LocationUpdateListener, a class that also access the same instance of GoogleApiClient (from the previous commit)
Synchronize LocationGMS
* Proguard is now renaming public classes so checked to static class based checks. - This way when Proguard renames the public class name it will be updated in OSUtils. - This is better then adding a proguard rule to keep class as allows renaming which means a smaller APK.
* This was not reliable after some additional testing on a device
• Fixes a crash (OneSignal#263) by disabling notification restoration after app upgrades for Android 7.0 devices.
• Fixes an out of date comment, this change only checks against a specific version of android (not a range)
• Fixes OneSignal#513, where in very rare cases a concurrency issue could occur where shared preferences was accessed during a buffer flush before the object was actually initialized • Fixed by adding synchronization to all accesses/initialization of this object
* Update location tracking * Fix NRE
# Conflicts: # OneSignalSDK/onesignal/src/main/java/com/onesignal/LocationGMS.java
baptiste-nv
added a commit
that referenced
this pull request
Mar 20, 2019
* Unity Proxy setLocationShared • Adds setLocationShared(bool) to the Unity proxy * Fixed runtime issue when firebase-auth is added * Specific when com.google.firebase:firebase-auth:15.1.0 is used the following error would throw - java.lang.IllegalArgumentException: Given String is empty or null - at com.google.android.gms.common.internal.Preconditions.checkNotEmpty(Unknown Source) - at com.google.firebase.auth.api.internal.zzcq.<init>(Unknown Source) - ... - at com.google.firebase.FirebaseApp.initializeApp(Unknown Source) - at com.onesignal.PushRegistratorFCM.initFirebaseApp(PushRegistratorFCM.java:64) * Synchronize State • Fixes a crash where the generateJsonDiff() method of the currentUserState property in UserStateSynchronizer is called before the currentUserState is initialized, by adding a synchronization step to the initUserState() method • Adds a check to make sure the user state is initialized before internalSyncUserState() attempts to access it. * Synchronize LocationGMS • The GoogleAPIClient instance in LocationGMS (accessed through a proxy via reflection) was being accessed before it was being connected due to a race condition • Introduces synchronization to ensure access to the instance only occurs after it is initialized & connected. * Synchronize LocationUpdateListener • Adds synchronization to LocationUpdateListener, a class that also access the same instance of GoogleApiClient (from the previous commit) * Fixed proguard compatibility * Proguard is now renaming public classes so checked to static class based checks. - This way when Proguard renames the public class name it will be updated in OSUtils. - This is better then adding a proguard rule to keep class as allows renaming which means a smaller APK. * Removed reading from META-INF files * This was not reliable after some additional testing on a device * Fix Notification Restoration Crash for Android 7.0 • Fixes a crash (OneSignal#263) by disabling notification restoration after app upgrades for Android 7.0 devices. * Update Comment • Fixes an out of date comment, this change only checks against a specific version of android (not a range) * Fix Null Pointer Concurrency Issue • Fixes OneSignal#513, where in very rare cases a concurrency issue could occur where shared preferences was accessed during a buffer flush before the object was actually initialized • Fixed by adding synchronization to all accesses/initialization of this object * 3.9.1 Release commit * Update location tracking (#1) * Update location tracking * Fix NRE * Add lat/long tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.