Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pointer after gzFile in NVHGzipFile.m #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kvaDrug
Copy link

@kvaDrug kvaDrug commented Feb 20, 2020

Commit message:

Fix the bug with gzFile: you should use it without * pointer. Otherwise the compiler will give the error: "Incompatible pointer types initializing 'gzFile *' (aka 'struct gzFile_s **') with an expression of type 'gzFile' (aka 'struct gzFile_s *')"

I believe it's a serious bug. Although, sometimes the existing code may work, it can lead to crashes.

P.S. Thanks for the project! Great job! I tried many pods to untar tar.gz and only this one works without problems. Let's do it even better!

…wise the compiler will give the error: "Incompatible pointer types initializing 'gzFile *' (aka 'struct gzFile_s **') with an expression of type 'gzFile' (aka 'struct gzFile_s *')"
@kvaDrug
Copy link
Author

kvaDrug commented Apr 21, 2020

@nvh, hi! Are you going to merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant