fix sorting when resting id

nvh · Apr 6, 2012 · 6de6532 · 6de6532
1 parent 15947fb
commit 6de6532
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/lib/spine.js b/lib/spine.js
diff --git a/src/spine.coffee b/src/spine.coffee
@@ -227,8 +227,8 @@ class Model extends Module
   @idCounter: 0
 
   @resetIdCounter: ->
-    ids = (model.id for model in @all()).sort()
-    @idCounter = (ids[ids.length - 1] or -1) + 1
+    ids        = (model.id for model in @all()).sort((a, b) -> a > b)
+    @idCounter = (parseInt(ids[ids.length - 1], 10) or -1) + 1
 
   @uid: (prefix = '') ->
     prefix + @idCounter++

diff --git a/test/specs/model.local.js b/test/specs/model.local.js
@@ -18,4 +18,9 @@ describe("Model.Local", function(){
     User.refresh([{name: "Bob", id: 1}]);
     expect(User.idCounter).toEqual(2);
   });
+
+  it("should work with non string IDs", function(){
+    User.refresh([{name: "Bob", id: "b"}]);
+    expect(User.idCounter).toEqual(0);
+  });
 });