feat: support non-english characters and responsive design #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nottyo
changed the title
nvh95
requested changes
Apr 18, 2022
demo/components/Translate.tsx
Outdated
| @@ -0,0 +1,14 @@ | |||
| const translate = () => { | |||
There was a problem hiding this comment.
Can you use the function component and make it PascalCase, just a convention :)
Suggested change
| const translate = () => { | |
| function translate(){ |
|
@nottyo Thanks for your PR. I left some comments. Could you please look into it? |
|
@nvh95 Thanks. I've fixed it. nottyo@9c39179 |
nvh95
reviewed
Apr 18, 2022
demo/components/Translate.tsx
Outdated
| @@ -0,0 +1,14 @@ | |||
| function translate(){ | |||
nvh95
approved these changes
Apr 18, 2022
|
@all-contributors please add @nottyo for code |
|
I've put up a pull request to add @nottyo! 🎉 |
|
@nottyo Thank you again. This change will land in |
|
Welcome to contributors! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
<meta charset="UTF-8">to html template to be able to render non English characters on Jest Preview Dashboard.<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no, viewport-fit=cover">to support responsive design on Jest Preview Dashboard.I added new component
Translateand add test to it.