Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove package-lock.json from examples #61

Merged
merged 1 commit into from Apr 20, 2022

Conversation

nvh95
Copy link
Owner

@nvh95 nvh95 commented Apr 19, 2022

Chores

@nvh95 nvh95 mentioned this pull request Apr 19, 2022
6 tasks
@thanhsonng
Copy link
Collaborator

@nvh95 can you elaborate on this practice? Why shouldn't package-lock.json be included?

@nvh95
Copy link
Owner Author

nvh95 commented Apr 20, 2022

@thanhsonng

  1. It bloats the size of PRs which are adding examples. That makes that information useless.

11789 new lines added, 0 lines removed

  1. Since all examples contain the jest-preview as a dependency, and dependencies of jest-preview change frequently, so all package-lock.json inside examples need to be updated accordingly. That's cumbersome.

  2. Examples' dependencies should always be "newest", to early detect and prevent the incompatible with Jest Preview. So we opt-out locking versions by removing package-lock.json.

  3. I just learn from NextJS's examples (https://github.com/vercel/next.js/tree/canary/examples)

@nvh95 nvh95 merged commit 6ac45ba into main Apr 20, 2022
@nvh95 nvh95 deleted the remove-package-lock-examples branch April 20, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants